fix for booting from USB with multiple devices

[leadog]

I believe I've found a fix for the USB boot failures when multiple devices are attached to the Sheevaplug via a hub. Looks like U-Boot was incorrectly determining the speed of the devices as it was probing the bus. Attached is a modified usb.c that can be applied to your build tree as well as a prebuilt flash image.

Please let me know if you have issues with this change. You know how newbie posters can be

FYI, I used the steps provided by http://plugcomputer.org/plugforum/index.php?topic=765.0 for setting up a U-Boot build.

[pc2000]

Probably useful to provide a diff


--- usb.c       2009-07-08 17:51:06.000000000 +1000
+++ usb.c.fix   2009-10-31 04:23:55.000000000 +1100
@@ -33,6 +33,11 @@
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
  * MA 02111-1307 USA
  *
+ *
+ *
+ * Oct 30, 2009 - Fix bus probing when multiple devices present.
+ *                Previous logic incorrectly determined device speed.
+ *                No copyright of any kind claimed, Lea Edel.
  */
 
 /*
@@ -743,7 +748,14 @@
        dev->epmaxpacketin

• = 8;

        dev->epmaxpacketout[0] = 8;
 
-    dev->speed = (0x0c000000 & (*(volatile unsigned int *)(0xf1050184))) >> 26;
+        if (dev->devnum <= 2)
+       {
+         /* Our built-in hub is a special case - we must check PORTSC reg.    */
+          /* This should not be here, it should be abstracted to a lower level */
+         /* somehow. I'm taking the shortcut of just fixing previous logic... */
+          dev->speed = (0x0c000000 & (*(volatile unsigned int *)(0xf1050184))) >> 26;
+        }
+
        /* We still haven't set the Address yet */
        addr = dev->devnum;
        dev->devnum = 0;

[OmahaVike]

the attached usbfix-image worked great for me.  thank you.  LEADDOGRULES

[odoll]

Hi leadog,

I believe I've found a fix for the USB boot failures [...] as well as a prebuilt flash image.

sorry for the naive question, however I guess the patches provided by pingtoo (see post http://plugcomputer.org/plugforum/index.php?topic=1134.msg7016#msg7016 and following) haven't been integrated into your u-boot image?!

Would you or sb else know, if your and pingtoo's (and maybe other fixes) were already merged into a "latest and greatest" image. (doubt I'd be experienced enough to build an image on my own (more likely bricking my plug ;-)))